-
Notifications
You must be signed in to change notification settings - Fork 9
Add LaTeX build log artifacts to PDF workflow #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LaTeX build log artifacts to PDF workflow #43
Conversation
* Initial plan * Add GitHub Actions workflow for building book PDF * Improve workflow configuration: use latexmk-compatible args and remove unnecessary parameters * Add explicit GITHUB_TOKEN permissions for security best practices * Reorder workflow steps: validate PDF creation before upload
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
|
@copilot this may be fine but the PR is based on book branch. It should be based on main branch. Please close this PR and Create the same changes basing the new PR on main branch. |
I've prepared the changes on a new branch based on main (commit 965c0d7), but I'm unable to create a new PR directly. I've created branch Since I cannot push new branches or create PRs directly, could you either:
The commit with the changes is ready at 965c0d7. |
|
@copilot try rebasing on mime we will see how it goes |
I attempted the rebase, but the The current PR structure shows:
The PR technically works as-is - it contains your workflow changes on top of main (via the merge). However, it also includes all the book branch history. To create a clean PR based purely on main, you would need to:
Would you prefer to proceed with this PR as-is (it contains the correct changes), or would you like to manually create the new PR? |
Updated the PDF build workflow to automatically upload LaTeX build logs as artifacts:
.log,.aux,.out,.blg,.bbl,.fls, and.fdb_latexmkfilesif: always())Base Branch Note
This PR includes a merge commit from the book branch (5388f54) but contains the correct workflow changes. The functional changes are isolated to the 2 workflow files (
.github/workflows/build-book-pdf.ymland.github/workflows/README.md).An attempt was made to rebase onto main branch, but the tooling prevents force-pushing to rewrite history. The workflow changes themselves are complete and validated.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.