Add close method to disconnect redis #7
Open
tomasvts wants to merge 2 commits intojochemstoel:mainfrom
Open
Conversation
Add close method that calls redis.disconnect
Owner
|
@tomasvts Did you suggest the change/patch for me to fix? |
Author
|
I mistakenly closed this PR after I deleted the branch. Sorry. I can create the branch again if you want, it's just three lines of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running procyon in k8s, or docker, the command never quits because there is an open connection to redis.
In order to support these environments, there should be a manual way to disconnect the redis connection.
This change exposes a
closemethod to allow the user close manually the connection whenever it's needed.