fix: normalize missing args for stdio MCP connections (closes #39)#42
Open
omatheusmesmo wants to merge 1 commit intojobrunr:mainfrom
Open
fix: normalize missing args for stdio MCP connections (closes #39)#42omatheusmesmo wants to merge 1 commit intojobrunr:mainfrom
omatheusmesmo wants to merge 1 commit intojobrunr:mainfrom
Conversation
) StdioTransportAutoConfiguration throws 'The args can not be null' when a stdio MCP server is saved to application.yaml without an explicit args list (e.g. when McpTool.addStdioMcpServer is called with blank args). McpStdioArgsNormalizerApplicationContextInitializer runs as an ApplicationContextInitializer before autoconfiguration, scans property sources for stdio connections that have a command but no args, and injects an empty args list so the binder never sees null.
|
We require contributors to sign our Contributor License Agreement, and we don't have @omatheusmesmo on file. In order for us to review and merge your code, please create a PR where you add yourself to the contributors of JobRunr. This only needs to be done once. As soon as that is done, we can review your PR. Thanks a lot! |
Author
Pr opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize missing 'args' for stdio MCP connections so autoconfiguration doesn't receive null. Adds ApplicationContextInitializer registered via META-INF/spring.factories and tests.\n\nBoot repro: verified app passes StdioTransportAutoConfiguration; subsequent failure is expected when command is invalid.\n\nSee commit 0cdd20f.
Fixes #39