Check if cpu.max file is non-empty before reading#479
Check if cpu.max file is non-empty before reading#479mindflayer wants to merge 11 commits intojoblib:masterfrom
Conversation
|
It seems that this make some test fails: |
|
It was a bit more complex than I firstly thought, and of course I had to try everything from an environment where Docker was setting everything up properly. |
tomMoral
left a comment
There was a problem hiding this comment.
Thanks a lot for investigating this.
It is indeed more complex than it looked 😅
This is just a few remarks from a quick look. The last test seems to not call the expected func?
The changes seem reasonable but I need more time to read them in detail, will try tomorrow.
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Take your time, I had this error happening for ages. Today the hidden boyscout in me thought it was the time to stop rebooting the system just to test this project of mine. :) |
|
@tomMoral anything more I could do for helping out here? |
tomMoral
left a comment
There was a problem hiding this comment.
Overall, LGTM, the change is reasonable and well tested.
Just a few more simplification for the code
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
|
I might be wrong, but the failure does not look like something related to this PR. |
Fix for #478