MNT Copy the CPython resource tracker code rather than derive from it#472
Open
lesteve wants to merge 6 commits intojoblib:masterfrom
Open
MNT Copy the CPython resource tracker code rather than derive from it#472lesteve wants to merge 6 commits intojoblib:masterfrom
lesteve wants to merge 6 commits intojoblib:masterfrom
Conversation
…all_error inside PY311 block
Contributor
|
There are teardown errors after Maybe we should directly sync with the code of the current +1 for using the same code style as in CPython and configure the linter to ignore this file to ease future synchronizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be preferable to avoid being affected by a CPython change in the future as in #459, especially since now we override the
_ensure_running_and_writemethod.I tried to mostly add the CPython 3.13.7 resource_tracker code from the non-overriden methods and left things out where I was able to quickly see it was not used e.g.
self._reentrant_messages.We could align the code even more in a further PR, e.g. single vs double quotes (easy mostly needs to tell black to ignore this file) or some other things (reentrant logic, some small logic change in
main, etc ...).