add listening-p function #33
Conversation
val314159
commented
Apr 16, 2021
val314159
commented
- adds in listening-p function
- fix typo in demo code
joaotavora
left a comment
joaotavora
left a comment
There was a problem hiding this comment.
Thanks. It's a good idea but please keep the comment inside the helper function you introduced.
| (defun control-frame-p (opcode) | ||
| (plusp (logand #x8 opcode))) | ||
|
|
||
| (defun listening-p (acceptor) |
There was a problem hiding this comment.
The comment that I had written above still applies here. We're still using an implementation detail. So please copy the comment here.
There was a problem hiding this comment.
I stuck a documentation string in here. does that work?
There was a problem hiding this comment.
Not really. Docstrings are about the external interface of a function. They whould exist and in this case should be.
Tell if the server ACCEPTOR is in a listening state.
Or
Return non-nil if server ACCEPTOR in listening state.
This is really a FIXME comment.
There was a problem hiding this comment.
how about that? (or maybe you want it at the end of the DEFUN line or the line after?)
There was a problem hiding this comment.
added in the DOCSTRING as well
val314159
force-pushed
the
feature-add-util-listening-p
branch
from
0204117 to
3318ba1
Compare
change incorrect DOCSTRING to a comment
added proper DOCSTRING as suggested
|
|
Let's add |
3 participants
