Skip to content

Conversation

@jaumebecks
Copy link
Contributor

Refactored docker setup:

  • Moved docker config to a docker/ folder
  • Added ability to build images per environment with the same Dockerfile
  • Added BUILD_ENV as .envvar
  • Created DEV environment

Performed tests:

  • docker-compose -f docker/docker-compose.yml build tests works (using requirements-test.txt)
  • make build works OR docker-compose -f docker/docker-compose.yml build python works (using requirements-dev.txt if BUILD_ENV is set in .env, and requirements-prod.txt the other way around)
  • envvars still exist in containers
  • docker-compose volumes still works (updated code outside a running container and was properly updated in the container)

@jaumebecks jaumebecks force-pushed the refactor-docker-setup branch from e212d2d to f284c4a Compare July 22, 2020 19:15
@jaumebecks jaumebecks force-pushed the refactor-docker-setup branch from f284c4a to 830d621 Compare August 6, 2020 12:05
@jaumebecks
Copy link
Contributor Author

Fixed conflicts and polished Makefile

@jaumebecks
Copy link
Contributor Author

Is there anything else to be done @joanfont ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants