Move release between folders / Remove from all folders #165
Conversation
|
Yo @AnssiAhola, I'm desperately trying to test a new feature and fail to mock this api: https://www.discogs.com/developers#page:user-collection,header:user-collection-change-rating-of-release Help! I left some debug messages in the models code as well as in the test. If you happen to find the time to check this out, that would be awesome. Thanks!!!! |
JOJ0
left a comment
JOJ0
left a comment
There was a problem hiding this comment.
Some inline comments so you understand what I'm thinking. Thanks!!!
clarifying that this removes from the collection entirely!!!
while also focusing on readability.
Allows info boxes with a syntax like this
:::{note}
Box contents
:::
JOJ0
force-pushed
the
foldermove
branch
3 times, most recently
from
e69b578 to
9a0b235
Compare
to include the new move_release and uncategorize_release methods but also clarify that remove_release removes from the collection entirely.
|
Ready for a final review. Nitpicks on code, docs wording and example-code appreciated! Also I did some slight refactoring in CollectionFolders class for more modern Python and activated a Sphinx-MyST-plugin that allows creating "info boxes", "attention boxes" and so on. You might like that @prcutler :-) I rendered docs changes for easier reviewing here: https://python3-discogs-client.readthedocs.io/en/foldermove/fetching_data.html#adding-a-release-to-a-collection-folder Thanks in advance |
I do like that! I will make some time and review this tomorrow. |
prcutler
left a comment
prcutler
left a comment
There was a problem hiding this comment.
Everything looks good to me, sorry for the delay.
|
@AnssiAhola I suppose no objections on your end since you had a look at the tests and code earlier already. I'll merge and release this now. On last thing: I see hanging python 3.6 and 3.7 checks. I think we should kick them out. I'll check that now.... |
|
The funny thing is, that 3.6 and 3.7 were not in our build workflow anymore. This looks like a github actions issue and might be temporary. I'll ignore it. Nevertheless I removed EOL 3.8 and added 3.13 to that workflow in f0d3af2 |
https://build.opensuse.org/request/show/1292513 by user dirkmueller + dimstar_suse - update to 2.8: * New collection folder methods `move_release` and `uncategorize_release` allowing to change folder of collection items * Add Python 3.13 to GitHub Actions build workflow and removed EOL Python 3.8 * Refactor some outdated Python code style along the way in joalla/discogs_client#165 - Update to 2.3.0
Fixes: #161
move_releaseanduncategorize_releaseusing this API which description is very misleading but it is able to change the collection folder of a collection item: https://www.discogs.com/developers#page:user-collection,header:user-collection-change-rating-of-release