Conversation
Owner
Author
|
Seems that we're actually fine for NC33, only for NC24, two tests are failing. Will try to fix this before merging/releasing. |
NC34 dropped support for callable-based addListener() in IEventDispatcher. Switch to IBootstrap/registerEventListener() with a dedicated AutoGroupsListener class. Hook config checks (creation/modification/login) move from AutoGroupsManager constructor to AutoGroupsListener::handle(). Also fixes AdminSettingsTest to use DI for IManager instead of the removed OC\Server::getSettingsManager(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace deprecated <filter><whitelist> and <logging> with <coverage><include> and <coverage><report><clover>. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test was broken under the old addListener() architecture because login_hook config was read at Application instantiation time (before the test set it), so the login listener was never registered. With the new AutoGroupsListener approach, hook config is checked at event dispatch time, so this now works correctly. Also removes the dependency on testRemoveHook having run first by explicitly setting up the initial group state in the test itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace der@digitalwerker.ch with josh@o23.ch in all files. Add AGPL-3.0 copyright header to appinfo/routes.php, css/admin.css, and standardize the existing shortened notice in js/admin.js. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
IUserSession::login() does not reliably fire events in the CLI test context (no real HTTP session), so the login hook was never triggered. Dispatch PostLoginEvent via IEventDispatcher directly instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was
linked to
issues
Mar 20, 2026
Closed
…nHook The original test used login() but was broken because a prior test left an active session, causing login() to short-circuit without dispatching events. Adding logout() first ensures a clean session state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
IUserSession::login() and logout() require HTTP session infrastructure unavailable in CLI test context (headers already sent error). Instead, dispatch PostLoginEvent via IEventDispatcher::dispatchTyped(), the same mechanism Nextcloud uses internally for all other integration tests in this suite. Use a dedicated fresh user to avoid state dependencies on other tests, and test both addition (no override group) and removal (in override group) in two phases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tale cache IGroup::inGroup() uses a per-object $users cache. After Phase 1 adds loginUser to auto groups, the local $autogroup1/$autogroup2 variables hold populated caches. When addAndRemoveAutoGroups() later calls removeUser() on different IGroup instances, the test-local objects' caches are not cleared, causing the Phase 2 assertion to see stale data. Re-fetching via groupManager->get() returns fresh objects with no cache, giving correct results. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Drop stable30 row (no longer supported), add stable33 row - Fix stable32 codecov flag (was incorrectly pointing to stable31) - Mark master/NC34 as experimental to match CI matrix - Remove "Union Groups" roadmap line from README and info.xml description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #87 and #88