refactor: update event handling to use ComfyEvent and ConnectionEvent#23
Merged
refactor: update event handling to use ComfyEvent and ConnectionEvent#23
Conversation
… for improved clarity
…tionEvent variants
There was a problem hiding this comment.
Pull Request Overview
This PR refactors event handling to leverage the new ComfyEvent and ConnectionEvent abstractions, removing the legacy ExecutedOutput and OtherEvent variants.
- Updated import paths and pattern matching to reflect the new event types
- Refactored tests, client event stream processing, and example code accordingly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration.rs | Updated event pattern matching in integration tests |
| src/meta.rs | Refactored event enums and executed output structure |
| src/lib.rs | Adjusted event stream handling to use new event types |
| examples/text_to_image.rs | Updated matching on event variants in example usage |
Comments suppressed due to low confidence (2)
examples/text_to_image.rs:193
- [nitpick] The warning message for unknown events currently logs a generic message. Consider including additional context—such as the expected event types—to improve debugging clarity.
ComfyEvent::Unknown(event) => {
src/lib.rs:526
- The fallback logic now wraps deserialization errors as ComfyEvent::Unknown. Ensure that all downstream consumers of Event are updated to handle this new variant appropriately.
match serde_json::from_value::<ComfyEvent>(value.clone()) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.