Fix CI Build Failure Caused by Prohibited Emoji#6
Draft
google-labs-jules[bot] wants to merge 14 commits intodevelopfrom
Draft
Fix CI Build Failure Caused by Prohibited Emoji#6google-labs-jules[bot] wants to merge 14 commits intodevelopfrom
google-labs-jules[bot] wants to merge 14 commits intodevelopfrom
Conversation
This change adds a check to the Inno Setup installers to ensure that the .NET 8 Desktop Runtime is installed before allowing the installation to proceed. If the runtime is not found, a message is displayed to the user with a link to the download page, and the installation is aborted. This addresses the issue where the installer would fail silently if the .NET runtime was not present. This change modifies the following installer scripts: - `release/pyrevit.iss` - `release/pyrevit-cli.iss` - `release/pyrevit-admin.iss`
This commit introduces a prerequisite check to the Inno Setup installers for pyRevit. The check verifies that the .NET 8 Desktop Runtime (or a later version) is installed on the system before allowing the installation to proceed. If the required runtime is not found, the installer will: 1. Display an informative message to the user. 2. Provide a link to the official .NET 8 download page. 3. Abort the installation process. This prevents the silent failure reported in the issue and provides a clear, actionable path for the user. The check has been added to the following installer scripts: - `release/pyrevit.iss` - `release/pyrevit-cli.iss` - `release/pyrevit-admin.iss`
This commit introduces a prerequisite check to the Inno Setup installers for pyRevit. The check verifies that the .NET 8 Desktop Runtime (or a later version) is installed on the system before allowing the installation to proceed. This is accomplished by adding a `[Code]` section to the installer scripts that uses the `InitializeWizard` event function. This function is called after the installer UI is initialized, allowing for a message box to be displayed reliably. If the required runtime is not found, the installer will: 1. Display an informative message to the user. 2. Provide a link to the official .NET 8 download page. 3. Abort the installation process. This prevents the silent failure reported in the issue and provides a clear, actionable path for the user. The check has been added to the following installer scripts: - `release/pyrevit.iss` - `release/pyrevit-cli.iss` - `release/pyrevit-admin.iss`
Add dotnet runtime check
This commit adds a diagnostic script to the Inno Setup installers. The script checks for the existence of the .NET 8 Desktop Runtime and displays its findings in a message box. This is a diagnostic step to confirm that the runtime detection logic is working correctly in the user's environment before implementing the final abort logic. The script has been added to the following installer files: - `release/pyrevit.iss` - `release/pyrevit-cli.iss` - `release/pyrevit-admin.iss` - `release/pyrevit-cli-admin.iss`
test: Add diagnostic check for .NET runtime to installers
This change introduces color to the pyrevit CLI's help messages to improve readability. - Added a new helper class `PyRevitCLIColorfulConsole` to encapsulate the logic for printing colored text to the console using the `Colorful.Console` library. - Refactored the `PyRevitCLIAppHelps` class to use the new helper class, printing help messages with color instead of building a single string. - Added a unit test to verify that the help message output contains color codes.
feat: Colorize CLI output
Removes the "prohibited" emoji from the `EmojiDict` to resolve a CI build failure. The character was causing issues with the build process, and a codebase search confirmed it was not in use.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the "prohibited" emoji from the
EmojiDictindev/pyRevitLabs/pyRevitLabs.Emojis/Emojis.cs. This emoji was causing the CI build to fail, and after a thorough search of the codebase, it was determined that the emoji is not being used anywhere in the project. This is a safe change that will allow the CI pipeline to pass without introducing any regressions.PR created automatically by Jules for task 14457705407553496349 started by @jmcouffin