Skip to content

Rawurlencode filenames when not using secure download links #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parapente merged 1 commit into from
Oct 26, 2024
Merged

Rawurlencode filenames when not using secure download links #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion attachments_component/site/tmpl/attachments/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* @author Jonathan M. Cameron
*/

use JMCameron\Component\Attachments\Site\Helper\AttachmentsDefines;
use Joomla\CMS\Factory;
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
Expand Down Expand Up @@ -172,7 +173,12 @@
$url = Route::_($base_url . "index.php?option=com_attachments&task=download&id=" . (int)$attachment->id);
}
else {
$url = $base_url . $attachment->url;
// We need to urlencode the filename
$offset = strlen(AttachmentsDefines::$ATTACHMENTS_SUBDIR."/{$attachment->parent_entity}/{$attachment->parent_id}/");
$url_path = mb_strcut($attachment->url, 0, $offset);
$url_filename = rawurlencode(mb_strcut($attachment->url, $offset));
$url = $base_url . $url_path . $url_filename;

if (strtoupper(substr(PHP_OS,0,3) == 'WIN')) {
// $url = utf8_encode($url); Deprecated from php 8.2
$url = iconv('ISO-8859-1', 'UTF-8', $url);
Expand Down