Skip to content

Fixes for install scripts #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
parapente wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixes for install scripts #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions attachments_component/install.attachments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,27 +200,6 @@ public function preflight(string $type, InstallerAdapter $adapter): bool
return false;
}

// If there is debris from a previous failed attempt to install Attachments, delete it
// NOTE: Creating custom query because using JComponentHelper::isEnabled insists on
// printing a warning if the component is not installed
$db = Factory::getContainer()->get('DatabaseDriver');
$query = $db->getQuery(true);
$query->select('extension_id AS id, enabled');
$query->from('#__extensions');
$query->where($query->qn('type') . ' = ' . $db->quote('component'));
$query->where($query->qn('element') . ' = ' . $db->quote('com_attachments'));
$db->setQuery($query);
if ($db->loadResult() == 0) {
if (
Folder::exists(JPATH_ROOT . '/components/com_attachments')
or Folder::exists(JPATH_ROOT . '/administrator/components/com_attachments')
) {
$msg = Text::_('ATTACH_ERROR_UINSTALL_OLD_VERSION');
$app->enqueueMessage($msg, 'error');
return false;
}
}

// Temporarily move the attachments directory out of the way to avoid conflicts
$attachdir = JPATH_ROOT . '/attachments';
if (Folder::exists($attachdir)) {
Expand Down