Fixed issues 3 and 4 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm991#3: ParentRig was removed in the previous commit, replaced reference in "CharacterControllerLogic.cs" with transform. jm991#4: The UnityEditor namespace isn't included in builds, which is causing the problem. You can move "ThirdPersonCameraEditor.cs" to a new folder called "Editor" (Unity arbitrarily excludes this folder from builds), and wrap the editor debug code in ThirdPersonCamera.cs in "#if UNITY_EDITOR" and "#endif" preprocessor statements to exclude them from builds.
Author
|
Hey John! As a side note, I'm still planning on modularizing this project and giving you those asset store images i was talking about a few months back (sorry it's been so long!). I'll try to get it done in the next couple days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3: ParentRig was removed in the previous commit, replaced reference in "CharacterControllerLogic.cs" with transform.
#4: The UnityEditor namespace isn't included in builds, which is causing the problem. You can move "ThirdPersonCameraEditor.cs" to a new folder called "Editor" (Unity arbitrarily excludes this folder from builds), and wrap the editor debug code in ThirdPersonCamera.cs in "#if UNITY_EDITOR" and "#endif" preprocessor statements to exclude them from builds.