remove x86 from darwin config#63
Closed
matthewcarlreetz wants to merge 3 commits intojlouis:masterfrom
Closed
Conversation
Adjust compile flags to support homebrew installed libsodium
|
Did you have an issue with homebrew libsodium that you needed to add those lines? In my PR for this issue (#60) just changing the arch indication worked on my m1 system with libsodium installed through homebrew. |
|
Nevermind, I see i forgot I had commented on the issue #53 about it and was exporting the CLIBS I think specifying the library location as you've done may break on intel based systems that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
-arch x86_64flag to allow build on arm64 Macs.