Merged
Conversation
Owner
|
@PaulSD thanks for making this PR, would you mind fixing the eslint errors? Once fixed I can merge this change in. |
Owner
|
I will merge and fix the linter errors in another commit to get this released. |
Contributor
Author
|
Ah, sorry, I thought I fixed it in the force-push a few days ago, but apparently I messed something up committing the fix. Regardless, thanks for fixing it and getting this released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filter()function requires an absolute path, not a relative path.This was breaking the
includeandexcludeoptions.