Skip to content

Conversation

@ss77995ss
Copy link

Description

Need Discussions

  • Currently all the params seem to work but I am not check completely. Might need more testing.
  • Test will not pass since the response data is different between legacy and latest leaderboard. Need some help for the testing data
  • Look like issue: MILB SCRAPE FROM NEW FANGRAPHS DATABASE #396 can also be fixed if we use fangraphs api link

TODO

  • Fix testing
  • Delete demo commit

* Using `requests.get` to get api response data directly rather than data crawling
* Some columns' response data format change so need to adjust them
* Let users can select which datasource they want to use
* Add `legacy=True` to get data from legacy leaderboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant