Update fangraphs month enum to support 'last x' games #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspotsthex
left a comment
markspotsthex
left a comment
There was a problem hiding this comment.
The Fangraphs URL would result in the appropriate time period with this change to the ENUMS.
This pull request is not blocked by #367, which appears to only affect when month is specified for in-season months (March-October).
|
Any update on this? @markspotsthex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fangraphs allows filtering leaderboards by last seven, fourteen and thirty days by setting the month to 1, 2, or 3 respectively.