Generalize the types of errors caught #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm somewhat-frequently seeing this as a result of github flake.
If you consult the library used for
github3, you can see that theConnectionErroris not a subclass ofgithub3.exceptions.GitHubErrorwhich is what is currently caught.This results in the test run being aborted with this error and something about an "internal error" in pytest. It also causes the pytest-mp to collect an inconsistent number of tests, which I can't fully understand now.
This change should catch both scenarios.