Open
Conversation
Author
|
On second thought, maybe |
Author
|
Changed the function name to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for this library!
I took @ocallarob's excellent changes from PR #30, rebased them on current master to resolve the conflict, squashed his three commits into one and made a few tweaks of my own:
static fdfToJSON()function isn't exposed by the module anymore. Instead, I introduced a new functionreadFdfAsJSON()that can be used instead ofgenerateFdf().output()and resolves the promise with the JSON directly. This allows more succinct code and imho fits better with the pure streaming API exposed by the rest of the module. Although returning a non-Buffer value from the promise is a new concept for this library, so please have a look if this is what you want.dump_data_fields_utf8output. Which is also easier to parse./Tand/Vbeing swapped, uses a longer / less common pattern for line splitting).Thanks to @ocallarob for the original changeset, hopefully this moves it in the right direction.