Skip to content

Check automatically Intel and Silicon MACS and minor fixes#85

Open
superbonaci wants to merge 4 commits intojivanpal:mainfrom
superbonaci:main
Open

Check automatically Intel and Silicon MACS and minor fixes#85
superbonaci wants to merge 4 commits intojivanpal:mainfrom
superbonaci:main

Conversation

@superbonaci
Copy link

@superbonaci superbonaci commented Sep 15, 2024

Some fixes thanks to https://github.com/PWhiddy/drat

  • Detect argp-standalone version without hard coding it thanks to brew symlink
  • Fix int open_container__info_stream
  • Add -Wno-unused-but-set-variable
  • Update README.md to include command to install argp-standalone in MAC

@jivanpal
Copy link
Owner

I'll review your suggested Makefile changes once I get my hands on an Intel Mac again, because I'm not familiar with how Homebrew has changed its default behaviour since the introduction of Apple Silicon.

@superbonaci
Copy link
Author

Fixes #82 #84

I've tested both in a virtual machine one with arm and other with intel x86_64.

@markst
Copy link

markst commented Jan 28, 2025

Confirmed working on arm64

ProductName:		macOS
ProductVersion:		15.3
BuildVersion:		24D60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

3 participants