Skip to content

Conversation

@damencho
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.87%. Comparing base (eac168d) to head (577d89a).

Files with missing lines Patch % Lines
...transcription/GoogleCloudTranscriptionService.java 0.00% 66 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #613      +/-   ##
============================================
- Coverage     19.00%   18.87%   -0.14%     
+ Complexity      307      306       -1     
============================================
  Files            83       83              
  Lines          7183     7222      +39     
  Branches        955      962       +7     
============================================
- Hits           1365     1363       -2     
- Misses         5594     5634      +40     
- Partials        224      225       +1     
Files with missing lines Coverage Δ
...transcription/GoogleCloudTranscriptionService.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac168d...577d89a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@damencho
Copy link
Member Author

It may needs adjusting the key settings on gcloud as I see such errors:

2025-11-10 17:11:22.983 WARNING: [26558] GoogleCloudTranscriptionService$ResponseApiStreamingObserver.onError#1134: jaas-transcriptions-382/1c9e8c86: received an error from the Google Cloud API
com.google.api.gax.rpc.PermissionDeniedException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: Permission 'speech.recognizers.recognize' denied on resource (or it may not exist).

We may want to split the impl or ... something ... and have both ...

@sliwken
Copy link

sliwken commented Dec 18, 2025

@damencho, thank you very much fro this change, I saw a new configuration GOOGLE_LOCATION to set location in recognizer resource name.
Regional API endpoint URL must match regional location (e.g. https://us-central1-speech.googleapis.com for the us-central1 location).
Could you also put a configuration to set regional endpoint when creating SpeechClient instance

SpeechSettings speechSettings = SpeechSettings.newBuilder().setEndpoint("us-central1-speech.googleapis.com:443").build();
SpeechClient client = SpeechClient.create(speechSettings);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants