add aws deployment #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
🥷 Code experts: no user matched threshold 10 See detailsTo learn more about /:\ gitStream - Visit our Docs |
… features, integration types, prerequisites, examples, and error handling.
![gitstream-cm[bot]](https://avatars.githubusercontent.com/in/230441?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…eration - Replaced shell script resource with REST API provider for creating state tokens. - Updated parameters in CloudFormation stack resources to retrieve tokens from the new REST API resource. - Configured REST API provider with global headers for authentication. - Updated Terraform version requirements to include the new REST API provider.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Introduced example Terraform configurations for integrating AWS organizations and single accounts with Jit. - Created `organization_integration.tf` and `variables.tf` for organization integration, including necessary variables and module configurations. - Created `account_integration.tf` and `variables.tf` for single account integration, detailing the required variables and module settings. - Both examples include configurations for Jit API integration and AWS provider settings.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Changed resource type from `aws_cloudformation_stack_set` to `aws_cloudformation_stack` for organization integration. - Removed auto deployment configuration and permission model settings that were previously associated with the StackSet. - Updated example Terraform configurations to include new capabilities for CloudFormation. - Added new `terraform.tfvars` files for organization and single account examples, including JIT API credentials and organizational settings.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Changed `resource_name_prefix` in `organization_integration.tf` to use a variable instead of a hardcoded value. - Added new variables for `regions_to_monitor`, `aws_region`, and `resource_name_prefix` in `variables.tf` for both organization and single account examples. - Updated `terraform.tfvars` files to include the new variables and their default values for better configurability.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Updated README.md to clarify the organization integration process, specifying that it creates a CloudFormation stack with internal StackSets. - Revised module names in examples for better clarity, changing `jit_aws_integration` to `jit_aws_account_integration`. - Added detailed explanations for required CloudFormation capabilities for both single account and organization integrations. - Improved validation notes for parameters and added comprehensive examples for both integration types, ensuring users have clear guidance on usage.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR Description
Purpose and impact: This PR introduces a Terraform module for automating AWS integration with JIT security platform, supporting both single account and organization-wide deployments.
Main changes: