Add support for MASM assembling #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
requested changes
Jul 7, 2023
| p.w(" deps = msvc") | ||
| p.w("") | ||
| p.w("rule asm") | ||
| p.w(" command = " .. asm .. " $ASMFLAGS" .. " /c /nologo /Zi /Fl\"\" /Fo$out /Ta $in") |
Collaborator
There was a problem hiding this comment.
Possibly:
Suggested change
| p.w(" command = " .. asm .. " $ASMFLAGS" .. " /c /nologo /Zi /Fl\"\" /Fo$out /Ta $in") | |
| p.w(" command = " .. asm .. " $ASMFLAGS" .. ' /c /nologo /Zi /Fl"" /Fo$out /Ta $in') |
| cxxflags = {"CXXFLAGS = $CXXFLAGS " .. getcxxflags(toolset, cfg, filecfg)} | ||
| end | ||
| add_build(cfg, objfilename, {}, "cxx", {filepath}, pch_dependency, regular_file_dependencies, cxxflags) | ||
| elseif shouldcompileasasm(filecfg) and toolset == p.tools.msc then |
Collaborator
There was a problem hiding this comment.
Why toolset filtering here?
I would prefer to handle "asm" in p.tools.gcc.gettoolname (to return "gcc").
|
|
||
| local extra = "" | ||
| if filecfg.exceptionhandling == "SEH" then | ||
| extra = extra .. " /safeseh" |
Collaborator
There was a problem hiding this comment.
That is msc specific :-/
Should ideally be in premake-core.
here, at least protect with toolset check.
See if it a workaround can be done in "Some toolset fixes/helper" section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with that my own project finally kinda builds :3
closes #27