Open
Conversation
torbsorb
force-pushed
the
ISSUE-4-remove-use_2to3
branch
from
bbb5712 to
843c701
Compare
graingert
reviewed
Sep 9, 2021
setup.py
Outdated
| rst2ast = rst2ast.cmd:run | ||
| """, | ||
| use_2to3 = True | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| """, | |
| python_requires=">=3.6", |
graingert
suggested changes
Sep 9, 2021
graingert
left a comment
graingert
left a comment
There was a problem hiding this comment.
you'll need to enable python_requires or people with python2 will accidentally install your version without py2 support
use_2to3 is no longer supported by setuptools. Let's deprecate Python 2 support, and remove the types `unicode` and `long`. @graingert suggested adding `python_requires`, thanks! Closes jimo1001#4
torbsorb
force-pushed
the
ISSUE-4-remove-use_2to3
branch
from
843c701 to
f06dccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_2to3 is no longer supported by setuptools. Let's deprecate Python 2
support, and remove the types
unicodeandlong.Closes 4