Shape up the app to follow coding best practices#1
Open
alex-anast wants to merge 26 commits intojim-kask:masterfrom
Open
Shape up the app to follow coding best practices#1alex-anast wants to merge 26 commits intojim-kask:masterfrom
alex-anast wants to merge 26 commits intojim-kask:masterfrom
Conversation
….env.example file
Author
|
@jim-kask Let me know what you think :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for the reviewer
I didn't change the logic. I just split it up to modular files with minimal functions that are testable.
Each function includes their own docstring and logging messages, as well as the file.
The
README.mdfiles have been updated and 59 (unit and integration) tests have been written -- that should massively help in further dev work.