Open
Conversation
sdroege
reviewed
Sep 2, 2020
| EBUR128_FILTER(float, -1.0f, 1.0f) | ||
| EBUR128_FILTER(double, -1.0, 1.0) | ||
|
|
||
| #define EBUR128_FILTER_PLANAR(type, min_scale, max_scale) \ |
There was a problem hiding this comment.
Instead of duplicating all this code, you could do access to the src samples via a macro that is defined differently for interleaved/planar. Something like
#define GET_SAMPLE_INTERLEAVED(src, channels, c, s) ((src)[(channels) * (s) + (c)])
#define GET_SAMPLE_PLANAR(src, channels, c, s) ((src)[(c)][(s)])Make such macro an argument to the existing FILTER / ADD_FRAMES macros and make use of them in there.
rafa852
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to be able to use planar samples instead of packed. This approach seemed to be the least error prone, but gives a bit of code duplication.