Open
Conversation
stringr::str_c() does recycling if no vector has length 1
Adapting tests to reflect code behavior: both alpha() and rgba() always append the alpha value (hex) at the end of the string with str_c
these colors are not found via chroma.hex() but chroma.css(), added TODO note to code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes I made to bring the package a bit closer to a CRAN release (see #11)
It does pass R CMD check now and I fixed other stuff, see below. However, there might be licensing issues with chroma.js if it's put on CRAN, I can't really tell. Also, CRAN might demand further changes in the docs.
In short @jiho: Feel free to use these edits but I'm afraid there might still be some back and forth necessary with CRAN to get it accepted. The package is usable as is, so it might not be worth the hassle...
Major changes:
urlchecker::urlcheck(). However, some links are no longer accessible, I changed the URLs to\code()This will probably not get accepted by CRAN.ggplot2to imports as too many functions use it to catch itscicolandscicol_info dataRemoved development features:
scale_vsup codeBugfixes:
alpha()example with recycled vectors to dontrunHousekeeping:
@noRdto v8 functions