LeetCode34 Done #68
Open
LeetCode34 Done #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int l = 0; | ||
| int r = nums.length - 1; | ||
|
|
||
| int midIdx = (l + r) / 2; |
Collaborator
There was a problem hiding this comment.
Not pretty sure why you put this outside.
I think you can directly calculate midIdx in each iteration in the while loop.
| }else { | ||
| break; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I can see in the first half of your code, you're trying to binary search on the position of your target, but I'm not sure why the latter part is trying to brute force all the positions.
Theoretically you should be able to find both points with binary search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time Complexity : O(logN)