Skip to content

Comments

Add SD SPI CMD24 write support#69

Merged
jhlagado merged 2 commits intomainfrom
work/tec1g-sd-write
Feb 9, 2026
Merged

Add SD SPI CMD24 write support#69
jhlagado merged 2 commits intomainfrom
work/tec1g-sd-write

Conversation

@jhlagado
Copy link
Owner

@jhlagado jhlagado commented Feb 9, 2026

Summary

  • implement CMD24 single-block write path in SD SPI emulator
  • add unit test covering data token + CRC + write response

Testing

  • not run

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jhlagado
Copy link
Owner Author

jhlagado commented Feb 9, 2026

Review: SD SPI CMD24 write support\n\n### Summary\n- Implements CMD24 (single-block write) in the SD SPI emulator.\n- Adds a unit test for data token, CRC, and write response.\n\n### Code Review\n- Write state machine is clear and robust: handles token, buffer, CRC, and commit.\n- logic is safe and bounds-checked.\n- Test covers the full write path and verifies image mutation.\n- refactor improves clarity for both read and write.\n\n### Suggestions\n- Consider adding a test for high-capacity (SDHC) write addressing.\n- Add a comment on the data response token (0x05) for future readers.\n- No functional issues found.\n\nLGTM. Ship it.\n\n_Reviewed via gh CLI as requested. Summary also posted in chat._

@jhlagado jhlagado merged commit 00c90ad into main Feb 9, 2026
0 of 2 checks passed
@jhlagado jhlagado deleted the work/tec1g-sd-write branch February 9, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant