Skip to content

Comments

Fix SD SPI block addressing and docs#67

Merged
jhlagado merged 3 commits intomainfrom
work/tec1g-sd-spi-hc
Feb 9, 2026
Merged

Fix SD SPI block addressing and docs#67
jhlagado merged 3 commits intomainfrom
work/tec1g-sd-spi-hc

Conversation

@jhlagado
Copy link
Owner

@jhlagado jhlagado commented Feb 9, 2026

Summary

  • add SDHC-aware OCR flag and block addressing in SD SPI emulator
  • cover SDHC block addressing in SdSpi tests
  • update TEC-1G docs to reflect SD/RTC emulation status

Testing

  • not run (test previously run on similar changes)

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jhlagado
Copy link
Owner Author

jhlagado commented Feb 9, 2026

Review: SD SPI block addressing and docs\n\n### Summary\n- Implements SDHC-aware OCR flag (CMD58) and block addressing for high capacity cards.\n- Updates docs and emulation review to reflect SD SPI as 95% complete.\n- Adds targeted test for CMD17 block addressing.\n\n### Code Review\n- now sets OCR[30] for SDHC, and block addressing logic is correct.\n- Test covers the block address/byte offset distinction.\n- Docs and emulation review are clear and up to date.\n\n### Suggestions\n- Consider adding a comment in to clarify the address calculation for future maintainers.\n- No functional issues found.\n\nLGTM. Ship it.\n\n_Reviewed via gh CLI as requested. Summary also posted in chat._

@jhlagado jhlagado merged commit befdea4 into main Feb 9, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant