Skip to content

Conversation

@jtkiesel
Copy link
Contributor

What changed with this PR:

Assignments with binary expressions (including those within the expression of a ternary) are now broken more similarly to the way Prettier does with JavaScript/TypeScript.

Example

Input

Aaaaaaaaaa aaaaaaaaaa = bbbbbbbbbb(cccccccccc, dddddddddd, eeeeeeeeee) != ffffffffff ? gggggggggg : hhhhhhhhhh;

Aaaaaaaaaa aaaaaaaaaa = bbbbbbbbbb(cccccccccccccccccccc, dddddddddddddddddddd, eeeeeeeeee) != ffffffffff ? gggggggggg : hhhhhhhhhh;

Aaaaaaaaaa aaaaaaaaaa = bbbbbbbbbb(cccccccccccccccccccc, dddddddddddddddddddd, eeeeeeeeeeeeeeeeeeee) != ffffffffff ? gggggggggg : hhhhhhhhhh;

var aaaaaaaaaa = bbbbbbbbbbbb || cccccccccc ? dddddddddd + eeeeeeeeee : ffffffffff + gggggggggg;

Output

Aaaaaaaaaa aaaaaaaaaa =
  bbbbbbbbbb(cccccccccc, dddddddddd, eeeeeeeeee) != ffffffffff
    ? gggggggggg
    : hhhhhhhhhh;

Aaaaaaaaaa aaaaaaaaaa =
  bbbbbbbbbb(cccccccccccccccccccc, dddddddddddddddddddd, eeeeeeeeee) !=
  ffffffffff
    ? gggggggggg
    : hhhhhhhhhh;

Aaaaaaaaaa aaaaaaaaaa =
  bbbbbbbbbb(
    cccccccccccccccccccc,
    dddddddddddddddddddd,
    eeeeeeeeeeeeeeeeeeee
  ) !=
  ffffffffff
    ? gggggggggg
    : hhhhhhhhhh;

var aaaaaaaaaa =
  bbbbbbbbbbbb || cccccccccc
    ? dddddddddd + eeeeeeeeee
    : ffffffffff + gggggggggg;

Output

Relative issues or prs:

Closes #788

@jtkiesel jtkiesel merged commit aedcd79 into jhipster:main Dec 28, 2025
6 checks passed
@jtkiesel jtkiesel deleted the fix/binary-expression-assignment-breaking branch December 28, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange formatting with a ternary

1 participant