Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions packages/prettier-plugin-java/src/comments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,44 +10,44 @@ import {
type JavaParserOptions
} from "./printers/helpers.js";

const formatterOffOnRangesByCst = new WeakMap<
const prettierIgnoreRangesByCst = new WeakMap<
JavaNode,
FormatterOffOnRange[]
PrettierIgnoreRange[]
>();

export function determineFormatterOffOnRanges(cst: JavaNonTerminal) {
export function determinePrettierIgnoreRanges(cst: JavaNonTerminal) {
const { comments } = cst;
if (!comments) {
return;
}
const ranges = comments
.filter(({ image }) =>
/^(\/\/\s*@formatter:(off|on)\s*|\/\*\s*@formatter:(off|on)\s*\*\/)$/.test(
/^\/(?:\/\s*(?:prettier-ignore-(?:start|end)|@formatter:(?:off|on))\s*|\*\s*(?:prettier-ignore-(?:start|end)|@formatter:(?:off|on))\s*\*\/)$/.test(
image
)
)
.reduce((ranges, { image, startOffset }) => {
const previous = ranges.at(-1);
if (image.endsWith("off")) {
if (previous?.on !== Infinity) {
ranges.push({ off: startOffset, on: Infinity });
if (image.includes("start") || image.includes("off")) {
if (previous?.end !== Infinity) {
ranges.push({ start: startOffset, end: Infinity });
}
} else if (previous?.on === Infinity) {
previous.on = startOffset;
} else if (previous?.end === Infinity) {
previous.end = startOffset;
}
return ranges;
}, new Array<FormatterOffOnRange>());
formatterOffOnRangesByCst.set(cst, ranges);
}, new Array<PrettierIgnoreRange>());
prettierIgnoreRangesByCst.set(cst, ranges);
}

export function isFullyBetweenFormatterOffOn(path: AstPath<JavaNode>) {
export function isFullyBetweenPrettierIgnore(path: AstPath<JavaNode>) {
const { node, root } = path;
const start = parser.locStart(node);
const end = parser.locEnd(node);
return (
formatterOffOnRangesByCst
prettierIgnoreRangesByCst
.get(root)
?.some(range => range.off < start && end < range.on) === true
?.some(range => range.start < start && end < range.end) === true
);
}

Expand Down Expand Up @@ -300,7 +300,7 @@ export type JavaComment = IToken & {
followingNode?: JavaNode;
};

type FormatterOffOnRange = {
off: number;
on: number;
type PrettierIgnoreRange = {
start: number;
end: number;
};
4 changes: 2 additions & 2 deletions packages/prettier-plugin-java/src/parser.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { parse } from "java-parser";
import type { Parser } from "prettier";
import { determineFormatterOffOnRanges } from "./comments.js";
import { determinePrettierIgnoreRanges } from "./comments.js";
import {
isTerminal,
type JavaNode,
Expand All @@ -14,7 +14,7 @@ export default {
cst.comments?.forEach(comment => {
comment.value = comment.image;
});
determineFormatterOffOnRanges(cst);
determinePrettierIgnoreRanges(cst);
return cst;
},
astFormat: "java",
Expand Down
4 changes: 2 additions & 2 deletions packages/prettier-plugin-java/src/printer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
canAttachComment,
handleLineComment,
handleRemainingComment,
isFullyBetweenFormatterOffOn
isFullyBetweenPrettierIgnore
} from "./comments.js";
import {
isNonTerminal,
Expand All @@ -26,7 +26,7 @@ export default {
node.comments?.some(({ image }) =>
/^(\/\/\s*prettier-ignore|\/\*\s*prettier-ignore\s*\*\/)$/.test(image)
) === true ||
(canAttachComment(node) && isFullyBetweenFormatterOffOn(path))
(canAttachComment(node) && isFullyBetweenPrettierIgnore(path))
);
},
canAttachComment,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// @formatter:off
// prettier-ignore-start
public class PrettierIgnoreClass {
public void myMethod(int param1, int param2, int param3, int param4, int param5, int param6, int param7, int param8, int param9, int param10) {

}
}
// @formatter:on
/* prettier-ignore-end */
public class PrettierIgnoreClass {
public void myMethod(int param1, int param2, int param3, int param4, int param5, int param6, int param7, int param8, int param9, int param10) {

}
}
// @formatter:off
/* @formatter:off */
public class PrettierIgnoreClass {
public void myMethod(int param1, int param2, int param3, int param4, int param5, int param6, int param7, int param8, int param9, int param10) {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// @formatter:off
// prettier-ignore-start
public class PrettierIgnoreClass {
public void myMethod(int param1, int param2, int param3, int param4, int param5, int param6, int param7, int param8, int param9, int param10) {

}
}

// @formatter:on
/* prettier-ignore-end */
public class PrettierIgnoreClass {

public void myMethod(
Expand All @@ -22,7 +22,7 @@ public void myMethod(
) {}
}

// @formatter:off
/* @formatter:off */
public class PrettierIgnoreClass {
public void myMethod(int param1, int param2, int param3, int param4, int param5, int param6, int param7, int param8, int param9, int param10) {

Expand Down