Improve MySQL support and export module.#122
Open
trans wants to merge 11 commits intojhartwell:masterfrom
Open
Improve MySQL support and export module.#122trans wants to merge 11 commits intojhartwell:masterfrom
trans wants to merge 11 commits intojhartwell:masterfrom
Conversation
Author
|
So I spent more time with this and worked out the kinks. At this point I think it's in pretty good shape (at least the MySQL side of things). I was able to do a full schema generation for Fishbowl, which is a huge messy database, with no errors or warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added most of the types that MySQL supports (all the ones that are straight forward).
I also made the Export module a little more resilient. If a type is
:nonethen it will still output the column but as a comment with:???as the type. Maybe it should not output anything, but at least this way it would be easy to go back and find where fixes are needed by hand.(Sorry about the four commits, not fully setup here yet so I had to do all this via the web.)