Skip to content

Support for nine-digits zip codes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredberger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for nine-digits zip codes #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/area/string.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ def to_area
#
# Returns a String of converted area codes or zipcodes.
def to_region(options = {})
if self.to_s.length == 3 # an area code
row = Area.area_codes.find {|row| row.first == self.to_s }
code = self.to_s
code = code[0..4] if code.match(/^\d{5}-?\d{4}$/)
if code.length == 3 # an area code
row = Area.area_codes.find {|row| row.first == code }
return row.last if row
elsif self.to_s.length == 5
if row = Area.zip_codes.find {|row| row.first == self.to_s }
if row.first == self.to_s
elsif code.length == 5
if row = Area.zip_codes.find {|row| row.first == code }
if row.first == code
if options[:city]
return row[1]
elsif options[:state]
Expand Down
10 changes: 10 additions & 0 deletions test/unit/area_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ def test_that_it_converts_zip_code_to_region
assert_equal "Brooklyn, NY", "11211".to_region
end

def test_that_it_supports_nine_digits_for_zipcodes
assert_equal "Brooklyn, NY", "11211-1111".to_region
assert_equal "Brooklyn, NY", "112111111".to_region
assert_equal "Brooklyn", "11211-1111".to_region(:city => true)
assert_equal "NY", "11211-1111".to_region(:state => true)
end

def test_that_it_supports_options_for_zipcodes
assert_equal "Brooklyn", "11211".to_region(:city => true)
assert_equal "NY", "11211".to_region(:state => true)
Expand Down Expand Up @@ -101,6 +108,9 @@ def test_that_it_returns_false_for_daylight_savings_time_nonobservance
def test_that_it_handles_incorrect_zips
assert_equal [], "9888".to_zip
assert_raises(ArgumentError) { "9888".to_region }
assert_raises(ArgumentError) { "988888".to_region }
assert_raises(ArgumentError) { "98888-44444".to_region }
assert_raises(ArgumentError) { "9888844444".to_region }
assert_raises(ArgumentError) { "9888".to_area }
assert_raises(ArgumentError) { "9888".to_gmt_offset }
assert_raises(ArgumentError) { "9888".to_dst }
Expand Down