Fix scss deprecation warnings #155
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses SCSS deprecation warnings by migrating from @import to @use directives and updating division operations to use math.div() instead of the deprecated slash-as-division syntax.
- Replaced all
@importstatements with@usefor SCSS modules - Updated function and mixin calls to use namespace prefixes (e.g.,
functions.pxToRem(),mixins.visualize-keyboard-focus()) - Replaced slash division with
math.div()in thepxToRem()function
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/style/typography.scss | Migrated to @use syntax with namespaced function/mixin calls |
| src/style/shadows.scss | Migrated to @use syntax with namespaced function calls |
| src/style/loading.scss | Added functions import and namespaced function calls |
| src/style/global-layout-rules.scss | Updated variable references to use namespace prefix, but missing functions import |
| src/style/functions.scss | Added sass:math import and replaced slash division with math.div() |
| src/style/colors.scss | Migrated to @use syntax with namespaced mixin calls |
| src/global/kompendium.scss | Converted @import to @use for SCSS modules |
| src/components/taglist/taglist.scss | Converted @import to @use |
| src/components/search/search.scss | Migrated to @use syntax with namespaced function/mixin calls |
| src/components/proplist/proplist.scss | Converted @import to @use |
| src/components/playground/playground.scss | Migrated to @use syntax with namespaced function/mixin/variable calls |
| src/components/navigation/navigation.scss | Migrated to @use syntax with namespaced function/mixin/variable calls |
| src/components/markdown/markdown.scss | Converted @import to @use |
| src/components/darkmode-switch/darkmode-switch.scss | Migrated to @use syntax with namespaced function/mixin calls |
| src/components/component/component.scss | Converted @import to @use |
| src/components/code/code.scss | Migrated to @use syntax with namespaced function/mixin calls, kept @import for external CSS |
| src/components/app/app.scss | Migrated to @use syntax with namespaced function/variable calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… built-in functions
adrianschmidt
force-pushed
the
fix-scss-deprecation-warnings
branch
from
29b059d to
0f03964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://sass-lang.com/documentation/breaking-changes/slash-div/
See: https://sass-lang.com/documentation/breaking-changes/import/
Testing
The changes here does not affect the build output in any way, it just updates some instances of code using deprecated APIs, thereby removing the deprecation warnings.