Open
Conversation
ZachTRice
commented
Feb 26, 2016
ZachTRice
commented
- Updated code to match v. 2.0 hosted on WordPress.org & incremented plugin to v. 2.0.1
- Changed Menu Container select box in ACF 4 & ACF 5 to radio checkbox. This fixes issue where saving always reverts menu container back to Nav.
- Updated code to match v. 2.0 hosted on WordPress.org - Changed Menu Container select box in ACF 4 & ACF 5 to radio checkbox
|
Hi @jgraup, any plans to merge this PR? Thanks! |
Owner
|
@tyrann0us - I think the original plugin has been updated to support ACF 5.0 so this repo is a bit out of date. See - http://wordpress.org/plugins/advanced-custom-fields-nav-menu-field/ If it makes sense to maintain this repo I guess I would but see if it's not needed. |
Author
|
This PR has the updates found on wordpress.org (2.0 changes) + change to radio select box. So, it might make sense to merge this and create a 2.0.1 release on here. Then carry over that radio select change to the wordpress.org version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.