Skip to content

add bower.json with dependencies on requirejs-text and mustache#3

Open
maxenglander wants to merge 1 commit intojfparadis:masterfrom
maxenglander:add-bower-support
Open

add bower.json with dependencies on requirejs-text and mustache#3
maxenglander wants to merge 1 commit intojfparadis:masterfrom
maxenglander:add-bower-support

Conversation

@maxenglander
Copy link
Copy Markdown

Hey @jfparadis, thanks for the useful plugin. I'm using bower to manage my dependencies. It would be great if your plugin supported bower. At a minimum, you'd need to create a tag (like 0.0.0) and merge this PR, and ideally register your plugin with bower register as well.

@Olical
Copy link
Copy Markdown

Olical commented Jul 28, 2013

What if you want to use requirejs-text in your own code? What if you need a different version? You would have to include multiple versions of the same script. I think the best approach is adding it to bower with no dependencies and leaving a guide to setting up Mustache and requirejs-text in your own code.

The current approach seem the most flexible to me. Although I would like to see official bower support with version tags.

@maxenglander
Copy link
Copy Markdown
Author

@Wolfy87 Not sure I follow. This PR would allow the bower user to use whatever mustache and requirejs-text versions they wanted, as long as they are above (the pretty generous) minimum.

@jfparadis
Copy link
Copy Markdown
Owner

Just a quick update, I've been reviewing the changes and I will port them to the 3 implementations of requires + template engine to keep feature parity. I though I thought I'd be done last week-end but there were lots of things on my end to clean-up, and I wanted to ramp-up on bower to have an educated opinion and accept the submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants