Open
Conversation
mstange
force-pushed
the
improve-perf
branch
from
be17f44 to
39069e9
Compare
mstange
force-pushed
the
improve-perf
branch
from
39069e9 to
56c1e62
Compare
mstange
commented
Dec 22, 2025
| @@ -334,17 +330,13 @@ impl LevelBuilder { | |||
| state_data.push(state.repl_cut as u8); | |||
| } | |||
| // Collect transitions into an array so we can sort them. | |||
Author
There was a problem hiding this comment.
Oops, need to remove this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Profiles of 10 iterations of hyf_compile with compress==false:
Before: https://share.firefox.dev/4pMrFnE (591 samples)
After: https://share.firefox.dev/4p9B5sz (204 samples)
I captured these profiles using the command
cargo build --profile profiling --bin hyf_compile && samply record -r 4000 --iteration-count 10 --reuse-threads ./target/profiling/hyf_compile ~/code/mozilla/intl/locales/en-US/hyphenation/hyph_en_US.dic /tmp/out.hyf