Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Conversation

@haad
Copy link

@haad haad commented Oct 19, 2018

Add new mode aws-sec-ssm which is using ssm parameters type SecureString which can be automatically decrypted by AWS KMS key. Add example terraform templates which can be used to create KMS key and secureString paramaters.

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL
Copy link
Contributor

JoshVanL commented Oct 25, 2018

/ok-to-test
Hi @haad , thanks for the PR. Please can you sign off and add a release note

haad added 3 commits October 25, 2018 17:31
Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
…ing which can be automatically decrypted by AWS KMS key. Add example terraform templates which can be used to create these from env variables.

Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
@haad
Copy link
Author

haad commented Oct 25, 2018

@JoshVanL here you go.

@JoshVanL
Copy link
Contributor

@haad Sorry, should have been more clear, it needs to be included in the root PR as described here https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md

and will look something like this #24

There looks to also be some problems with go vet :)

haad added 2 commits October 26, 2018 11:10
Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
Signed-off-by: Adam Hamsik <adam.hamsik@chillisys.com>
@JoshVanL
Copy link
Contributor

JoshVanL commented Nov 7, 2018

/assign @haad

@haad
Copy link
Author

haad commented Nov 7, 2018

@JoshVanL This should do it :)

@JoshVanL
Copy link
Contributor

JoshVanL commented Nov 7, 2018

@haad Thanks, I'll take a look when I get the chance :)
/assign

@jetstack-bot
Copy link
Collaborator

@haad: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@charlieegan3 charlieegan3 removed their request for review February 9, 2021 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants