Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Conversation

@JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Sep 7, 2018

NONE

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot
Copy link
Collaborator

@JoshVanL: GitHub didn't allow me to assign the following users: sime.

Note that only jetstack members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

NONE

/assign @sime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL JoshVanL changed the title Update vendor and adds dep ensure dry run to make verify WIP: Update vendor and adds dep ensure dry run to make verify Sep 7, 2018
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL changed the title WIP: Update vendor and adds dep ensure dry run to make verify Update vendor and adds dep ensure dry run to make verify Sep 7, 2018
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Sep 7, 2018

/assign @simonswine

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot
Copy link
Collaborator

@JoshVanL: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants