Fix: Treat partial class template specializations correctly#136
Open
fknorr wants to merge 1 commit intojessevdk:masterfrom
Open
Fix: Treat partial class template specializations correctly#136fknorr wants to merge 1 commit intojessevdk:masterfrom
fknorr wants to merge 1 commit intojessevdk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cldoc currently does not generate nodes for partial template class specializations. It still tries to process its children, which receive the containing namespace as parent (fallback). This causes problems elsewhere, e.g. if the child is a method, it expects its parent to be a class.
This PR models partial template class specializations as class templates, fixing this issue. The change requires Node types to map to multiple kinds.