Conditional attributes#172
Open
D3X wants to merge 16 commits intojessemiller:masterfrom
D3X:conditional-attributes
Open
Conditional attributes#172D3X wants to merge 16 commits intojessemiller:masterfrom D3X:conditional-attributes
D3X wants to merge 16 commits intojessemiller:masterfrom
D3X:conditional-attributes
Conversation
Added new test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional boolean attributes were requested by a few people (See #111), but no one has actually made any effort in solving this issue. When I started working on supporting conditional attributes (not only booleans), I realised a proper parser would be a good idea. This PR replaces the simple attribute parser with a proper pyparsing-based one. An actual grammar is defined and can be extended if needed.
Tests and documentation of the new features are included. Some PEP8 changes too.