New functionality and some bugfixes in analysis of nested archives #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 20, 2013 17:01
reviewed coding conventions and javadoc; tattletale properties can be sed in Ant project instead of property file; fixed a related NPE in Configuration; new take on TTALE-199; support for adapters (RAR) and partial extraction of archives
Added readme.txt Changed some report names Reviewed exceptions
I had introduced a massive amount of duplications in Scanners; Reports could not get paths in links straight, especially for nested archives (besides redundant code)
It is better to clear floats rather than envelop the entire report body in a paragraph (I was confused by <p/> :-)
Owner
|
The best thing is to create a forum post which explains the changes before any development is done. So do that now, and we can leave the PR open until we find the changes needed. Thanks |
Added new task attributes/properties Revised report names Added warning about old report names to Main for backwards compatibility
Reports need not to extend Severity/Status because Main decides what failOnInfo/Warning/Error is. Otherwise, there must be a way to tell Main how to interpret the semantics of extended Severity/Status, which would unnecessarily complicate the API.
keep dependencies compatible to Java 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is acceptable for a review; please let me know if you would like the changes to be split into patches for different themes (HTML generation, bundling of class files/component analysis, Java 5/style).