Merged
Conversation
modified: src/Scope/Renaming.agda modified: src/Scope.agda modified: src/Scope/Renaming.agda modified: src/Scope.agda Date: Tue Jan 21 09:56:14 2025 +0100 Changes to be committed: modified: src/Scope.agda modified: src/Scope/Renaming.agda Untracked files: result Changes to be committed: modified: src/Scope.agda modified: src/Scope/Renaming.agda
Changes to be committed: modified: src/Scope/Renaming.agda Changes to be committed: modified: src/Scope/Renaming.agda Changes to be ignored: modified: src/Scope/Diff.agda
jespercockx
reviewed
Jan 21, 2025
| subRight : α ⋈ β ≡ γ → β ⊆ γ | ||
| subRight p = < splitComm p > | ||
| {-# COMPILE AGDA2HS subRight inline #-} | ||
| {-# COMPILE AGDA2HS subRight #-} |
Collaborator
Author
There was a problem hiding this comment.
I don't know exactly why: the test complained about it and erasing it did the trick, so I didn't look further.
src/Scope/Renaming.agda
Outdated
| diffCase (inToSub xp) yp | ||
| (λ _ → < Zero ⟨ IsZero refl ⟩ >) | ||
| (λ yp' → let ⟨ _ ⟩ res = permutationToRenamingRev p < yp' > in < inThere res >) | ||
| {-# COMPILE AGDA2HS permutationToRenamingRev #-} No newline at end of file |
Owner
There was a problem hiding this comment.
Please make sure to add a newline at the end of the file (tip: you can enable files.insertFinalNewline in VS Code to do it automatically).
src/Scope/Renaming.agda
Outdated
| → Permutation (x ◃ α) β | ||
| {-# COMPILE AGDA2HS Permutation deriving Show #-} | ||
|
|
||
| {- |
Owner
There was a problem hiding this comment.
Do we still need this version for anything?
Collaborator
Author
There was a problem hiding this comment.
No, I'll erase it in the next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.