Skip to content

As it is, mouse positions are incorrect if the camera is a child of ... #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Faleij wants to merge 1 commit into
base: master
Choose a base branch
from
Open

As it is, mouse positions are incorrect if the camera is a child of ... #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions threex.domevent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ THREEx.DomEvent.prototype._onMove = function(mouseX, mouseY, origDomEvent)
var vector = new THREE.Vector3( mouseX, mouseY, 1 );
this._projector.unprojectVector( vector, this._camera );

var ray = new THREE.Ray( this._camera.position, vector.subSelf( this._camera.position ).normalize() );
var pos = this._camera.matrixWorld.getPosition().clone();
var ray = new THREE.Ray( pos, vector.subSelf( pos ).normalize() );
var intersects = ray.intersectObjects( this._boundObjs );

var oldSelected = this._selected;
Expand Down Expand Up @@ -250,8 +251,9 @@ THREEx.DomEvent.prototype._onEvent = function(eventName, mouseX, mouseY, origDom
var vector = new THREE.Vector3( mouseX, mouseY, 1 );
this._projector.unprojectVector( vector, this._camera );

vector.subSelf( this._camera.position ).normalize()
var ray = new THREE.Ray( this._camera.position, vector );
var pos = this._camera.matrixWorld.getPosition().clone();
vector.subSelf( pos ).normalize()
var ray = new THREE.Ray( pos, vector );
var intersects = ray.intersectObjects( this._boundObjs );

// if there are no intersections, return now
Expand Down