[JENKINS-60434] Allow pipelines to continue running when preparing for shutdown#846
Open
ajkyffin wants to merge 1 commit intojenkinsci:masterfrom
Open
[JENKINS-60434] Allow pipelines to continue running when preparing for shutdown#846ajkyffin wants to merge 1 commit intojenkinsci:masterfrom
ajkyffin wants to merge 1 commit intojenkinsci:masterfrom
Conversation
jglick
requested changes
Feb 9, 2024
Member
jglick
left a comment
There was a problem hiding this comment.
Likely functionally incomplete, deserves some test coverage, and ought to be an explicit option at the GUI (or CLI etc.) level rather than a system property. See discussion in Jira.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents pipelines from being paused when preparing for shutdown. No new parts of pipelines are scheduled to executors but parts already running can run to completion, allowing Jenkins to be restarted without any running jobs.
This is disabled by default and enabled by setting
-Dorg.jenkinsci.plugins.workflow.cps.CpsThreadGroup.keepPipelinesRunningWhenQuietingDown=true.This provides a solution for https://issues.jenkins.io/browse/JENKINS-60434.
Testing done
The default case is covered by existing tests in
CpsFlowExecutionTest.java.For the case with
-Dorg.jenkinsci.plugins.workflow.cps.CpsThreadGroup.keepPipelinesRunningWhenQuietingDown=true: