JENKINS-48431 Support both lightweight checkout AND build parameters#329
Closed
tgatinea wants to merge 1 commit intojenkinsci:masterfrom
Closed
JENKINS-48431 Support both lightweight checkout AND build parameters#329tgatinea wants to merge 1 commit intojenkinsci:masterfrom
tgatinea wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This was referenced Oct 14, 2019
Closed
This was referenced May 25, 2020
Closed
dwnusbaum
reviewed
Jul 2, 2020
Comment on lines
-5
to
-6
| Also build parameters will not be substituted into SCM configuration in this mode. | ||
| Only selected SCM plugins support this mode. |
Member
There was a problem hiding this comment.
I think it is important to still note that not all SCMs that support lightweight checkouts, and that even the ones that do support lightweight checkout do not all support build parameters, so maybe change the wording to something like this instead:
Only selected SCM plugins support this mode.
Build parameters may be substituted into SCM configuration in this mode when running SCM API plugin X.Y.Z or newer. Not all SCM plugins support this feature.
Member
|
Superseded by #577? |
Member
Yeah looks like it, so I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-48431 To support both lightweight checkout AND build parameters, we need to:
This leads to implement a new method :
public static SCMFileSystem of(@nonnull Run build, @nonnull SCM scm, @checkfornull SCMRevision rev)
This new method offer the capacity to recover the environments parameter of the build as the current build is propagated through the new method.
Note that this modification is in relation with two other pull requests that concerns: