-
-
Notifications
You must be signed in to change notification settings - Fork 113
Allow releasing bound objects via HTTP #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Fine it it works. |
| * | ||
| * @throws HttpResponses.HttpResponseException expected outcome returning 200 OK | ||
| */ | ||
| public void doRelease(StaplerRequest2 req, StaplerResponse2 rsp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@POST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, although I expect this would be replaced anyway due to
The current implementation sends one request per proxy, could be collapsed to just one if this approach is deemed preferable.
|
I wonder if it would not be better to just deprecate |
Experimental alternative to #663.
I expect time-based expiration to be problematic (#663 (comment)) so this instead allows releasing bound objects when navigating away from the page that registered the proxies.
Pros: Proxies continue to exist until you leave the page.
Cons: Browser involvement needed, a page can accumulate proxies in badly-written code. Probably more.
The current implementation sends one request per proxy, could be collapsed to just one if this approach is deemed preferable.
Testing done
With jenkinsci/jenkins#10631:
t:artifactListlazily jenkins#10623 (comment): EmptySubmitter checklist