Skip to content

Conversation

@rompic
Copy link

@rompic rompic commented Jan 4, 2015

improved keyword matching in link annotator

case insensitive keywords
matches multiple occurrences (e.g. refs #12, closes #13)
allows spaces and colons
workaround for (#12,#13 and #1 text)
additional tests

I came up with the following fix for some of our legacy projects and
https://issues.jenkins-ci.org/browse/JENKINS-24373

Maybe there is a more elegant solution (e.g. getting the „offset“ from
the SCM), but as I’m new to jenkins plugin dev I would need some
pointers.
case insensitive keywords
matches multiple occurrences (e.g. refs jenkinsci#12, closes jenkinsci#13)
allows spaces and colons
workaround for (jenkinsci#12,jenkinsci#13 and jenkinsci#1 text)
additional tests
This rolls back to commit e628f09.
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ngoc-minh-do
Copy link

I found some weird behaviour when using some commit message with:

  • Redmine tag in first place. Ex: It work with " #7600" but not "#7600"
  • Redmine tag with multi line
    11

@bmaehr
Copy link

bmaehr commented Apr 16, 2020

Parsing ticket numbers seams not to work like described in documentation.
"Ref #123456 some text" is not linked but "Ref #123456 - some text" works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants